Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] self-hosted-runner pattern/regex #359

Closed
jenseng opened this issue Sep 28, 2023 · 7 comments
Closed

[feature] self-hosted-runner pattern/regex #359

jenseng opened this issue Sep 28, 2023 · 7 comments

Comments

@jenseng
Copy link

jenseng commented Sep 28, 2023

I'm using self-hosted runners, but the labels are not statically knowable, as they can include dynamic parameters, e.g.

runs-on: [self-hosted, "some-base-prefix:size=large&cpu=8"]

While it looks like I could either turn off the runner-label rule, and/or define my own rule with OnRulesCreated and use actionlint programmatically, it would be awesome if actionlint itself had some more flexibility around how to lint these labels. Not necessarily fully exhaustive, just being able to do a regex or glob style pattern would be great.

@dekimsey
Copy link

dekimsey commented Nov 2, 2023

This would be great, I'd love to have some glob support here as we run into the same issue ourselves!

@kishaningithub
Copy link
Contributor

For some reason this issue did not come up in the search and i created a similar ticket. Linking it here

#377

@kishaningithub
Copy link
Contributor

@jenseng Let know if my proposal #377 would also work for you

@kishaningithub
Copy link
Contributor

@jenseng / @dekimsey Have created a PR address this #378 feel free to put in your feedback in the PR as well

@jenseng
Copy link
Author

jenseng commented Nov 8, 2023

This is great, thanks @kishaningithub!

@MPV
Copy link

MPV commented Nov 28, 2023

For ideas/context, here's someone else doing the equivalent of this (in a related kind of solution):

@rhysd
Copy link
Owner

rhysd commented Feb 10, 2024

Closing as #378. Now glob pattern is supported.

@rhysd rhysd closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants