Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: detect invalid use of working-directory option with action #207

Closed
chrisRedwine opened this issue Aug 27, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@chrisRedwine
Copy link

The working-directory option can only be used in run steps, but not in actions (i.e., not with uses).

For example, the following workflow should fail analysis:

on:
  workflow_dispatch:
jobs:
  foo:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v3
        working-directory: foo/

But it currently succeeds.

I think it'd be useful to add this check. Thanks for the great tool, btw!

@rhysd rhysd added the bug Something isn't working label Aug 28, 2022
@rhysd rhysd closed this as completed in a1c9bd5 Aug 28, 2022
@rhysd
Copy link
Owner

rhysd commented Aug 28, 2022

Thanks. It was bug of actionlint.

@rhysd
Copy link
Owner

rhysd commented Aug 28, 2022

This was fixed in v1.6.17.

rhysd added a commit that referenced this issue Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants