Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive about the input of octokit/[email protected] #16

Closed
iwata opened this issue Jul 28, 2021 · 1 comment
Closed

false positive about the input of octokit/[email protected] #16

iwata opened this issue Jul 28, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@iwata
Copy link

iwata commented Jul 28, 2021

actionlint allows only mediaType and route as input for octokit/[email protected].
https://github.com/rhysd/actionlint/blob/main/popular_actions.go#L2415-L2430

But it's false positive, because request-action v2 allows other inputs.
ref. https://github.com/octokit/request-action#inputs
They are simply treated as request parameters to the API.

@rhysd
Copy link
Owner

rhysd commented Jul 28, 2021

Oh, OK, so request-action allows any request parameters as inputs though they are not defined in action.yml. I'll fix this.

@rhysd rhysd added the bug Something isn't working label Jul 28, 2021
@rhysd rhysd closed this as completed in 1591a40 Jul 28, 2021
rhysd added a commit that referenced this issue Jul 28, 2021
rhysd added a commit that referenced this issue Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants