Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actionlint does not support outputs parameters in reusable workflow #119

Closed
oyri opened this issue Mar 2, 2022 · 2 comments
Closed

Actionlint does not support outputs parameters in reusable workflow #119

oyri opened this issue Mar 2, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@oyri
Copy link

oyri commented Mar 2, 2022

Error message:

.github/workflows/test-job-output.yml:14:5: unexpected key "outputs" for "workflow_call" section. expected one of "inputs", "secrets" [syntax-check]
   |
14 |     outputs:
   |     ^~~~~~~~

Version installed: 1.6.9

installed by downloading from release page
built with go1.17.7 compiler for linux/amd64

Code-example that runs correct functionally:

on:
  workflow_call:
    inputs:
      image-name:
        description: Name of Docker image
        required: true
        type: string
    outputs:
      image-version:
        description: "Docker image version"
        value: ${{ jobs.generate-image-version.outputs.imagetag }}
jobs:
  generate-image-version:
      runs-on: ubuntu-latest
....

Github outputs doc: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow.

I hope you can include this new functionallity in your code as well. :)

@timothysparg
Copy link

Just stumbled across this as well, if you're using it directly looks like you can at least bypass that rule. See - #91

@rhysd rhysd added the bug Something isn't working label Mar 7, 2022
rhysd added a commit that referenced this issue Mar 7, 2022
note that this only checks syntax. expression in `outputs.value` and
outputs in caller are not checked yet.
@rhysd
Copy link
Owner

rhysd commented Mar 7, 2022

This issue was fixed by dbe43b2.

@rhysd rhysd closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants