Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3289: github action to update downstream version in CMO #1

Closed
wants to merge 1 commit into from

Conversation

slashpai
Copy link
Member

This commit adds a github action listener for branch delete event which
happens when upstream -> downstream PR is merged with openshift repos.
Once the event occurs, newly added action invokes rhobs/syncbot workflow
which creates PR to bump the version.yaml.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

… event which

happens when upstream -> downstream PR is merged with openshift repos.
Once the event occurs, newly added action invokes rhobs/syncbot workflow
which creates PR to bump the version.yaml.

Signed-off-by: Jayapriya Pai <[email protected]>
@simonpasquier
Copy link

Looking at other rhobs repositories, I'm not sure that the workflow is useful? For instance https://github.com/rhobs/prometheus-operator/actions/workflows/update-version.yaml has no run in the recent months. I think that we rely on the periodic https://github.com/rhobs/syncbot/actions/workflows/update-cmo-deps-versions.yaml instead.

@slashpai
Copy link
Member Author

Looking at other rhobs repositories, I'm not sure that the workflow is useful? For instance https://github.com/rhobs/prometheus-operator/actions/workflows/update-version.yaml has no run in the recent months. I think that we rely on the periodic https://github.com/rhobs/syncbot/actions/workflows/update-cmo-deps-versions.yaml instead.

sure, I think we can wait on this then. I will review after downstream is updated once rhobs/syncbot#55 is merged

@slashpai slashpai closed this Aug 10, 2023
monitoring-commit-bot bot pushed a commit that referenced this pull request Apr 4, 2024
Vulnerability #1: GO-2024-2611
    Infinite loop in JSON unmarshaling in google.golang.org/protobuf
  More info: https://pkg.go.dev/vuln/GO-2024-2611
  Module: google.golang.org/protobuf
    Found in: google.golang.org/[email protected]
    Fixed in: google.golang.org/[email protected]
    Example traces found:
      #1: json.Decoder.Peek
      #2: json.Decoder.Read
      openshift#3: protojson.Unmarshal
      openshift#4: protojson.UnmarshalOptions.Unmarshal

Signed-off-by: Damien Grisonnet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants