Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Sprite Yeet PR (ie safely remove sprites) #24

Merged
merged 7 commits into from
Feb 23, 2022

Conversation

patataofcourse
Copy link
Member

Fixes #23. Also adds a small confirmation dialogue when replacing a sprite that is being used in any animations.
image

@CebolaBros64 CebolaBros64 self-requested a review February 20, 2022 22:12
@CebolaBros64
Copy link
Contributor

Implementation-wise everything seems to check out. Apart from the change I requested as a comment, I have a few more suggestions to the UX side of things:

  • As of right now, the title of the alert window only tells the user the index of the animation. I believe this isn't very useful to the end user, and that having the animation's name in place would make more sense. (Ex.: "Sprite used in animation rishiki_beat_blue")
  • It feels redundant to have two alerts confirming that the sprite is going to be deleted. Just one alert is fine.

BTW, you may also add yourself to the list in rhmodding/bread/utils/Credits.kt if you feel so inclined 🎉

@patataofcourse
Copy link
Member Author

Okay, I'll add all these changes and lyk when it's done

* Animation name instead of animation number on delete tab (BCCAD only)
@CebolaBros64 CebolaBros64 merged commit 47baba1 into rhmodding:master Feb 23, 2022
@patataofcourse patataofcourse deleted the sprite-yeet branch March 11, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Animations don't adjust for deleted sprites
2 participants