Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dracut: Disable ostree-prepare-root #44

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

licliu
Copy link
Collaborator

@licliu licliu commented Oct 11, 2024

Since #41 has already been merged into main, let's merge this commit from #28 and then close it.

In some images such as the recent fedora/rhel bootc base image,
the ostree dracut module is statically enabled:
https://gitlab.com/fedora/bootc/base-images/-/blob/40df0eb3827763039e4d17264968e37f850b70e5/tier-0/initramfs.yaml#L9

And also recently, we changed the ostree systemd unit
to enter emergency.target if it fails in:
ostreedev/ostree@05b3b66

These two things combine mean we'll fail before kdump gets
a chance to run.

For our use case we don't need ostree in the initrd.

I tried to override this with `--omit=ostree` in our dracut
invocation, but that causes an error (dracut doesn't let the
cmdline override static config).

For now, let's just mask the service in our initrd.

Signed-off-by: Colin Walters <[email protected]>
Reviewed-by: Lichen Liu <[email protected]>
@licliu licliu requested a review from coiby October 11, 2024 05:42
Copy link
Member

@coiby coiby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@coiby coiby merged commit 2503c4f into rhkdump:main Oct 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants