Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RESULT validation #1279

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jkonecny12
Copy link
Member

Currently if RESULT file has an issue after the "SUCCESS" word it will tell success. That works in most of the cases but not if validation is done in the %post of KS but also later in the .sh file.

If %post section was fine and add SUCCESS but validation section will found issue it would take the whole test as successful.

Fix this in all the impacted tests and also in the functions.sh.

Currently if RESULT file has an issue after the "SUCCESS" word it will
tell success. That works in most of the cases but not if validation is
done in the %post of KS but also later in the .sh file.

If %post section was fine and add SUCCESS but validation section will
found issue it would take the whole test as successful.

Fix this in all the impacted tests and also in the functions.sh.
@jkonecny12
Copy link
Member Author

/test-tmt

@jkonecny12
Copy link
Member Author

/test-os-variants

@jkonecny12 jkonecny12 requested a review from rvykydal August 12, 2024 10:12
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@jkonecny12 jkonecny12 merged commit 879933b into rhinstaller:master Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants