Move product.py to core #5002
Merged
Move product.py to core #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kickstart-test --testtype smoke |
poncovka
approved these changes
Aug 3, 2023
poncovka
approved these changes
Aug 3, 2023
|
Waiting to coordinate with oscap folks. Presumably it would be better to wait with this until after branching. |
M4rtinK
approved these changes
Aug 3, 2023
|
Just a small typo in one of the commit messages:
|
|
OSCAP people say this is fine for rawhide, so I'd wait for when we do the branching, unless we absolutely require this for webui. |
This means, do not import anything from product to constants that woudl be then re-imported elsewhere from constants.
Generally speaking, move `pyanaconda.product.distributionText` to `pyanaconda.ui.helpers.get_distribution_text` and convert all uses.
VladimirSlavik
force-pushed
the
master-core-product
branch
from
a09c824
to
20e7580
Compare
|
Rebased to lastest master. |
|
/kickstart-test --testtype smoke |
|
/packit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring in advance of adding D-Bus API for this and such.
Not sure how far I will go with this yet, so no TODO list.Let's take it piecewise. This is a good foundation, is still reasonably sized, and it does not makes sense to mix in the other changes that will have their own challenges.Side note - the changes have potential to break initial setup due to touching the UI class constructor.Disproved by kickstart tests below.