Enable /boot on btrfs subvolume with GRUB2

[npmccallum]

This depends on a version of grubby with btrfs subvolume support. For
example, grubby >= 8.40-10.fc29.

[npmccallum]

I tested this patch with the Fedora 27 Workstation media. Before running Anaconda I updated to a new build of grubby on the live media and patched the Anaconda code. After running it I proceeded with installation like normal (except with /boot on a btrfs subvolume). Installation completed successfully and the system came up after reboot.

[Conan-Kudo]

😂

[Conan-Kudo]

Can we also have this merged into the F28 branch? There will be a grubby update with the necessary code for F28 too.

[npmccallum]

Agreed. However, we need grubby to land in F28 first. This is planned, but we're waiting for the freeze so that people can test the bodhi update.

[jkonecny12]

Jenkins, it's ok to test.

[jkonecny12]

If you want this to F28 you need to make this PR against the f28-devel branch. After merge it will be propagated to the master automatically.

[npmccallum]

@vathpela It appears we need to land grubby in F28 so that we can land the anaconda patch in both F28 and F29.

[npmccallum]

https://koji.fedoraproject.org/koji/buildinfo?buildID=1054332
https://bodhi.fedoraproject.org/updates/grubby-8.40-10.fc28

I have applied for a F28Beta freeze exception for grubby and anaconda. Please test grubby so that we can get it out of bodhi.

[npmccallum]

Here is another approach that allows easy testing of the feature but does not enable it by default:
#1400

[dustymabe]

For right now the anaconda team is very busy with other features and some code base changes. This feature will be considered after some time. Will work with @snbueno to make sure it doesn't get lost.

[vlad0337187]

Waiting this to Fedora 28 =)

[ghost]

@dustymabe @snbueno When will this be in f28, this problem is still in the F28 Beta and I don't want to install till this is fixed. If openSUSE, Ubuntu, Arch, Debian, etc can have /boot in the btrfs subvolume so can Fedora.

[Conan-Kudo]

@snbueno We're now long after Fedora 28 has released, can we please have this merged now for Fedora 29?

[mildred]

If you really need it, you can change it at runtime on the intaller and then log in to console and issue systemctl restart anaconda.

[Conan-Kudo]

@mildred That's a horrible suggestion. It's not that difficult to enable the logic in Anaconda, so we should just pull it in.

[mildred]

I was installing fedora silverblue (ex atomic host) and didn't have the separate partitions for /boot. Unfortunately silverblue boot process doesn't support /boot on btrfs and I had to trick it fot it to work... So, yes, that was an horrible suggestion :)

[vlad0337187]

This is still not merged =)
Interesting, why ?

[dustymabe]

It's possible the anaconda team has dug themselves out of the mountain of work they were under and could enable this for Fedora rawhide now. Team, any thoughts?

[poncovka]

Jenkins, test this please.

[jkonecny12]

Hello everyone,

Thanks for your support and patient.
We started a discussion about this issue again. However, right now we are waiting for the rest of the team. There will be holiday soon in US so part of our team aren't at work anymore. We will continue the discussion after the holidays ends.

We will tell you more after that.
For people from US following this issue, have a great Thanksgiving!

[Conan-Kudo]

@jkonecny12 Any progress?

[jkonecny12]

Hello, sorry about the delay I didn't forget.
The problem is that we are still waiting for confirmation to actually implement this so we are working on that. I'm repeatedly asking on status so I hope it will move soon but can't commit to a date. :(

[Conan-Kudo]

@jkonecny12 Any movement? 🙏

[jkonecny12]

@Conan-Kudo sorry but no, I don't have any news. If you want to push this forward you can contact @snbueno . She's the one who I'm pinging about this.
I would recommend you to use mail, you will find her mail through the link in her profile.

[awehrfritz]

Is this working on the upcoming Fedora 30? If no, any particular reason why?

[jkonecny12]

Sorry but the same as before. If you want more info please contact @snbueno about this.

[jkonecny12]

Hello guys, please look here if you agree with the terms.

[jkonecny12]

@npmccallum @Conan-Kudo you are free to rebase this and prepare this for a merge.

[Conan-Kudo]

This pull request is obsoleted by #2255 now, where I've rebased the change accordingly.

[jkonecny12]

Closing.