Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistencies #71

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: inconsistencies #71

merged 1 commit into from
Jun 17, 2024

Conversation

kopy-kat
Copy link
Member

No description provided.

@kopy-kat
Copy link
Member Author

this fixes W4

@@ -22,8 +22,11 @@ abstract contract TrustManagerExternalAttesterList is IRegistry, TrustManager {
*/
function check(address module, address[] calldata attesters, uint256 threshold) external view {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeroknots do you think we should require sorted here? this might break some stuff so might be best not to? otherwise we'd need to sort them here imo

Copy link

fix: inconsistencies

Generated at commit: 512c6cb4c2fab0595d580a7daa84256cc2c89964

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
5
25
33
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@kopy-kat kopy-kat merged commit 97f4716 into audit/fix Jun 17, 2024
2 of 4 checks passed
@kopy-kat kopy-kat deleted the audit/fix-inconsistencies branch June 17, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant