Feature/simple structs

.gas-snapshot

@@ -1,116 +1,64 @@
-AttestationDelegationTest:testAttest() (gas: 236648)
-AttestationDelegationTest:testAttest__RevertWhen_InvalidSignature() (gas: 81170)
-AttestationDelegationTest:testAttest__RevertWhen__InvalidExpirationTime() (gas: 73233)
-AttestationDelegationTest:testAttest__RevertWhen__InvalidSchema() (gas: 70222)
-AttestationDelegationTest:testAttest__RevertWhen__ValidatorSaysInvalidAttestation() (gas: 104060)
-AttestationDelegationTest:testAttest__RevertWhen__ZeroImplementation() (gas: 73470)
-AttestationDelegationTest:testAttest__With__LargeAttestation() (gas: 441774)
-AttestationDelegationTest:testMultiAttest() (gas: 578947)
-AttestationDelegationTest:testMultiAttest__RevertWhen__InvalidExpirationTime() (gas: 265063)
-AttestationDelegationTest:testMultiAttest__RevertWhen__InvalidLength__DataLength() (gas: 20162)
-AttestationDelegationTest:testMultiAttest__RevertWhen__InvalidLength__SignatureLength() (gas: 206475)
-AttestationDelegationTest:testMultiAttest__RevertWhen__InvalidSchema() (gas: 261042)
-AttestationDelegationTest:testMultiAttest__RevertWhen__InvalidSignature() (gas: 235207)
-AttestationDelegationTest:testMultiAttest__RevertWhen__ValidatorSaysInvalidAttestation() (gas: 296139)
-AttestationDelegationTest:testMultiAttest__RevertWhen__ZeroImplementation() (gas: 263236)
-AttestationDelegationTest:testMultiRevoke() (gas: 633003)
-AttestationDelegationTest:testMultiRevoke__RevertWhen__AlreadyRevoked() (gas: 558562)
-AttestationDelegationTest:testMultiRevoke__RevertWhen__AttestationNotFound() (gas: 209073)
-AttestationDelegationTest:testMultiRevoke__RevertWhen__InvalidSchema() (gas: 539260)
-AttestationDelegationTest:testMultiRevoke__RevertWhen__NotOriginalAttester() (gas: 541378)
-AttestationDelegationTest:testRevoke() (gas: 273156)
-AttestationDelegationTest:testRevoke__RevertWhen__AlreadyRevoked() (gas: 291040)
-AttestationDelegationTest:testRevoke__RevertWhen__AttestationNotFound() (gas: 75469)
-AttestationDelegationTest:testRevoke__RevertWhen__InvalidSchema() (gas: 265566)
-AttestationDelegationTest:testRevoke__RevertWhen__InvalidSignature() (gas: 248016)
-AttestationResolveTest:testResolveAttestation() (gas: 17596)
-AttestationResolveTest:testResolveAttestation__RevertWhen__InsufficientValue() (gas: 20228)
-AttestationResolveTest:testResolveAttestation__RevertWhen__InvalidAttestation() (gas: 20780)
-AttestationResolveTest:testResolveAttestation__RevertWhen__InvalidRevocation() (gas: 20779)
-AttestationResolveTest:testResolveAttestation__RevertWhen__ResolverNotPayableAndValue() (gas: 20158)
-AttestationResolveTest:testResolveAttestation__RevertWhen__ZeroResolverAndValue() (gas: 16986)
-AttestationResolveTest:testResolveAttestation__WithValue() (gas: 59730)
-AttestationTest:testAttest() (gas: 193660)
-AttestationTest:testAttest__RevertWhen__InvalidExpirationTime() (gas: 32875)
-AttestationTest:testAttest__RevertWhen__InvalidSchema() (gas: 29936)
-AttestationTest:testAttest__RevertWhen__ValidatorSaysInvalidAttestation() (gas: 63769)
-AttestationTest:testAttest__RevertWhen__ZeroImplementation() (gas: 33023)
-AttestationTest:testAttest__With__LargeAttestation() (gas: 395795)
-AttestationTest:testMultiAttest() (gas: 513538)
-AttestationTest:testMultiAttest__RevertWhen__InvalidExpirationTime() (gas: 200172)
-AttestationTest:testMultiAttest__RevertWhen__InvalidSchema() (gas: 196284)
-AttestationTest:testMultiAttest__RevertWhen__ValidatorSaysInvalidAttestation() (gas: 231345)
-AttestationTest:testMultiAttest__RevertWhen__ZeroImplementation() (gas: 229241)
-AttestationTest:testMultiRevoke() (gas: 551479)
-AttestationTest:testMultiRevoke__RevertWhen__AlreadyRevoked() (gas: 558396)
-AttestationTest:testMultiRevoke__RevertWhen__AttestationNotFound() (gas: 208979)
-AttestationTest:testMultiRevoke__RevertWhen__InvalidSchema() (gas: 539188)
-AttestationTest:testMultiRevoke__RevertWhen__NotOriginalAttester() (gas: 541269)
-AttestationTest:testRevoke() (gas: 213801)
-AttestationTest:testRevoke__RevertWhen__AlreadyRevoked() (gas: 227300)
-AttestationTest:testRevoke__RevertWhen__AttestationNotFound() (gas: 40523)
-AttestationTest:testRevoke__RevertWhen__InvalidSchema() (gas: 211825)
-AttestationTest:testRevoke__RevertWhen__NotOriginalAttester() (gas: 210649)
-DeployRegistryTest:testRun() (gas: 4410056)
-EIP712VerifierTest:testGetAttestationDigest() (gas: 20149)
-EIP712VerifierTest:testGetNonce() (gas: 48032)
-EIP712VerifierTest:testGetRevocationDigest() (gas: 18470)
-EIP712VerifierTest:testVerifyAttest() (gas: 45158)
-EIP712VerifierTest:testVerifyAttest__RevertWhen__InvalidSignature() (gas: 39033)
-EIP712VerifierTest:testVerifyRevoke() (gas: 43400)
-MockRegistryTest:testCheck() (gas: 5721)
-MockRegistryTest:testCheckN() (gas: 7714)
-MockRegistryTest:testCheckNUnsafe() (gas: 7779)
-ModuleTest:testCreate3() (gas: 185945)
-ModuleTest:testDeployNoArgs() (gas: 205604)
-ModuleTest:testDeployWithArgs() (gas: 229119)
-ModuleTest:testExternalFactory() (gas: 345659)
-ModuleTest:testNonexistingModule__ShouldRevert() (gas: 78682)
-ModuleTest:testReRegisterModule__ShouldRevert() (gas: 214236)
-QueryTest:testAttest() (gas: 193660)
-QueryTest:testAttest__RevertWhen__InvalidExpirationTime() (gas: 32942)
-QueryTest:testAttest__RevertWhen__InvalidSchema() (gas: 30003)
-QueryTest:testAttest__RevertWhen__ValidatorSaysInvalidAttestation() (gas: 63814)
-QueryTest:testAttest__RevertWhen__ZeroImplementation() (gas: 33112)
-QueryTest:testAttest__With__LargeAttestation() (gas: 395862)
-QueryTest:testCheckAttestation() (gas: 195317)
-QueryTest:testCheckAttestation__RevertWhen__AttestationNotExistent() (gas: 13120)
-QueryTest:testCheckAttestation__RevertWhen__Expired() (gas: 241325)
-QueryTest:testCheckAttestation__RevertWhen__Revoked() (gas: 215496)
-QueryTest:testCheckNAttestation() (gas: 405642)
-QueryTest:testCheckNAttestationUnsafe() (gas: 410171)
-QueryTest:testCheckNAttestationUnsafe__Expired() (gas: 410898)
-QueryTest:testCheckNAttestationUnsafe__RevertWhen__ThresholdNotMet() (gas: 211730)
-QueryTest:testCheckNAttestationUnsafe__Revoked() (gas: 426993)
-QueryTest:testCheckNAttestation__RevertWhen__Expired() (gas: 479262)
-QueryTest:testCheckNAttestation__RevertWhen__Revoked() (gas: 445299)
-QueryTest:testCheckNAttestation__RevertWhen__ThresholdNotMet() (gas: 204623)
-QueryTest:testFindAttestation() (gas: 197162)
-QueryTest:testFindAttestations() (gas: 410019)
-QueryTest:testMultiAttest() (gas: 513560)
-QueryTest:testMultiAttest__RevertWhen__InvalidExpirationTime() (gas: 200194)
-QueryTest:testMultiAttest__RevertWhen__InvalidSchema() (gas: 196284)
-QueryTest:testMultiAttest__RevertWhen__ValidatorSaysInvalidAttestation() (gas: 231389)
-QueryTest:testMultiAttest__RevertWhen__ZeroImplementation() (gas: 229241)
-QueryTest:testMultiRevoke() (gas: 551657)
-QueryTest:testMultiRevoke__RevertWhen__AlreadyRevoked() (gas: 558418)
-QueryTest:testMultiRevoke__RevertWhen__AttestationNotFound() (gas: 209001)
-QueryTest:testMultiRevoke__RevertWhen__InvalidSchema() (gas: 539188)
-QueryTest:testMultiRevoke__RevertWhen__NotOriginalAttester() (gas: 541269)
-QueryTest:testRevoke() (gas: 213934)
-QueryTest:testRevoke__RevertWhen__AlreadyRevoked() (gas: 227499)
-QueryTest:testRevoke__RevertWhen__AttestationNotFound() (gas: 40545)
-QueryTest:testRevoke__RevertWhen__InvalidSchema() (gas: 211847)
-QueryTest:testRevoke__RevertWhen__NotOriginalAttester() (gas: 210649)
-RegistryGasComparisonTest:testGasCheck() (gas: 24415)
-RegistryGasComparisonTest:testGasCheckN__Given__ThreeAttesters() (gas: 52861)
-RegistryGasComparisonTest:testGasCheckN__Given__TwoAttesters() (gas: 39735)
-SchemaTest:testRegisterResolver() (gas: 57007)
-SchemaTest:testRegisterResolver__RevertWhen__AlreadyExists() (gas: 62681)
-SchemaTest:testRegisterResolver__RevertWhen__InvalidResolver() (gas: 11707)
-SchemaTest:testRegisterSchema() (gas: 60515)
-SchemaTest:testRegisterSchema__RevertWhen__AlreadyExists() (gas: 63133)
-SchemaTest:testSetResolver() (gas: 63593)
-SimpleRegistryIntegrationTest:testGasRegistryCheck() (gas: 200478)
-TokenizedResolverTest:testTokenizedResolver() (gas: 510680)
-ValueResolverTest:testValueResolver() (gas: 490959)
+AttestationTest:test_WhenAttestingToNon_existingModule(address,uint48,bytes,uint32[]) (runs: 256, μ: 23689, ~: 23329)
+AttestationTest:test_WhenAttestingWithExpirationTimeInThePast(address,bytes,uint32) (runs: 256, μ: 16593, ~: 16549)
+AttestationTest:test_WhenAttestingWithNoAttestationData() (gas: 275618)
+AttestationTest:test_WhenAttestingWithTooHighModuleType(address,uint48,bytes,uint32) (runs: 256, μ: 18309, ~: 18706)
+AttestationTest:test_WhenAttesting_ShouldCallResolver() (gas: 180325)
+AttestationTest:test_WhenReAttestingToARevokedAttestation() (gas: 336471)
+AttestationTest:test_WhenRevokingAttestationThatDoesntExist(address) (runs: 256, μ: 28098, ~: 28098)
+AttestationTest:test_WhenRevokingWithValidECDSA() (gas: 240190)
+AttestationTest:test_WhenRevokingWithValidECDSAMulti() (gas: 409757)
+AttestationTest:test_WhenTokensAreNotPaid() (gas: 210)
+AttestationTest:test_WhenTokensArePaid() (gas: 232)
+AttestationTest:test_WhenUsingInvalidECDSA() (gas: 51597)
+AttestationTest:test_WhenUsingInvalidECDSAMulti() (gas: 59947)
+AttestationTest:test_WhenUsingInvalidERC1271() (gas: 45292)
+AttestationTest:test_WhenUsingInvalidERC1271Multi() (gas: 51080)
+AttestationTest:test_WhenUsingValidECDSA() (gas: 224126)
+AttestationTest:test_WhenUsingValidECDSAMulti() (gas: 385144)
+AttestationTest:test_WhenUsingValidERC1271() (gas: 211437)
+AttestationTest:test_WhenUsingValidERC1271Multi() (gas: 371364)
+ImmutableData:invariant_attestation_immutable() (runs: 1200, calls: 24000, reverts: 7425)
+ImmutableData:invariant_balance() (runs: 1200, calls: 24000, reverts: 7425)
+ImmutableData:invariant_resolver_immutable() (runs: 1200, calls: 24000, reverts: 7425)
+ImmutableData:invariant_schema_immutable() (runs: 1200, calls: 24000, reverts: 7425)
+ModuleRegistrationTest:test_WhenDeployingViaRegistry() (gas: 130398)
+ModuleRegistrationTest:test_WhenDeployingViaRegistryWithArgs() (gas: 153516)
+ModuleRegistrationTest:test_WhenRegisteringAModuleOnAInValidResolverUID() (gas: 74823)
+ModuleRegistrationTest:test_WhenRegisteringAModuleOnAValidResolverUID() (gas: 105730)
+ModuleRegistrationTest:test_WhenRegisteringAModuleOnAnInvalidResolverUID() (gas: 81381)
+ModuleRegistrationTest:test_WhenRegisteringTwoModulesWithTheSameBytecode() (gas: 108559)
+ModuleRegistrationTest:test_WhenRegisteringViaFactory() (gas: 219570)
+ModuleRegistrationTest:test_WhenUsingInvalidFactory() (gas: 16406)
+ModuleRegistrationTest:test_WhenUsingRegistryASFactory() (gas: 13561)
+ResolverTest:test_WhenNewResolver() (gas: 285233)
+ResolverTest:test_WhenResolverAlreadyRegistered() (gas: 282816)
+ResolverTest:test_WhenUsingAuthorizedAccount() (gas: 511780)
+ResolverTest:test_WhenUsingUnauthorizedAccount() (gas: 285133)
+SchemaValidationTest:test_WhenSchemaAlreadyRegistered() (gas: 108072)
+SchemaValidationTest:test_WhenSchemaNew() (gas: 53779)
+TrustTest:test_WhenAttesterSetButNoAttestationMade() (gas: 253)
+TrustTest:test_WhenAttestersSetAndAllOk() (gas: 285080)
+TrustTest:test_WhenAttestersSetButThresholdTooLow() (gas: 188)
+TrustTest:test_WhenAttestingToNon_existingModule(address,uint48,bytes,uint32[]) (runs: 256, μ: 23718, ~: 23357)
+TrustTest:test_WhenAttestingWithExpirationTimeInThePast(address,bytes,uint32) (runs: 256, μ: 16570, ~: 16527)
+TrustTest:test_WhenAttestingWithNoAttestationData() (gas: 275596)
+TrustTest:test_WhenAttestingWithTooHighModuleType(address,uint48,bytes,uint32) (runs: 256, μ: 18480, ~: 18728)
+TrustTest:test_WhenAttesting_ShouldCallResolver() (gas: 180392)
+TrustTest:test_WhenNoAttestersSet() (gas: 39131)
+TrustTest:test_WhenReAttestingToARevokedAttestation() (gas: 336493)
+TrustTest:test_WhenRevokingAttestationThatDoesntExist(address) (runs: 256, μ: 28120, ~: 28120)
+TrustTest:test_WhenRevokingWithValidECDSA() (gas: 240168)
+TrustTest:test_WhenRevokingWithValidECDSAMulti() (gas: 409823)
+TrustTest:test_WhenSupplyingManyAttesters(address[]) (runs: 256, μ: 1326050, ~: 1326696)
+TrustTest:test_WhenSupplyingOneAttester() (gas: 42650)
+TrustTest:test_WhenSupplyingSameAttesterMultipleTimes() (gas: 13159)
+TrustTest:test_WhenTokensAreNotPaid() (gas: 210)
+TrustTest:test_WhenTokensArePaid() (gas: 232)
+TrustTest:test_WhenUsingInvalidECDSA() (gas: 51619)
+TrustTest:test_WhenUsingInvalidECDSAMulti() (gas: 59925)
+TrustTest:test_WhenUsingInvalidERC1271() (gas: 45292)
+TrustTest:test_WhenUsingInvalidERC1271Multi() (gas: 51169)
+TrustTest:test_WhenUsingValidECDSA() (gas: 224126)
+TrustTest:test_WhenUsingValidECDSAMulti() (gas: 385122)
+TrustTest:test_WhenUsingValidERC1271() (gas: 211437)
+TrustTest:test_WhenUsingValidERC1271Multi() (gas: 371342)

.github/workflows/ci.yaml

@@ -0,0 +1,26 @@
+on:
+  - push
+  - pull_request
+
+jobs:
+  lint:
+    uses: "rhinestonewtf/reusable-workflows/.github/workflows/forge-lint.yaml@main"
+
+  build:
+    uses: "rhinestonewtf/reusable-workflows/.github/workflows/forge-build.yaml@main"
+
+  test-unit:
+    needs: ["lint", "build"]
+    uses: "rhinestonewtf/reusable-workflows/.github/workflows/forge-test.yaml@main"
+    with:
+      foundry-fuzz-runs: 5000
+      foundry-profile: "test"
+      match-path: "test/**/*.sol"
+      name: "Unit tests"
+
+  coverage:
+    needs: ["build"]
+    uses: "rhinestonewtf/reusable-workflows/.github/workflows/forge-coverage.yaml@main"
+    with:
+      match-path: "test/**/*.sol"
+      codecov-slug: zeroknots/registry

.github/workflows/gh-pages.yaml

@@ -0,0 +1,27 @@
+name: github pages
+
+on:
+  - push
+
+jobs:
+  deploy:
+    runs-on: ubuntu-20.04
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Setup mdBook
+        uses: peaceiris/actions-mdbook@v1
+        with:
+          mdbook-version: "0.4.10"
+          # mdbook-version: 'latest'
+
+      - run: cd docs; mdbook build
+
+      - name: Deploy
+        uses: peaceiris/actions-gh-pages@v3
+        if: ${{ github.ref == 'refs/heads/main' }}
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          publish_dir: ./docs/book

.github/workflows/slither.yaml

@@ -0,0 +1,8 @@
+name: Slither Analysis
+on: [push]
+jobs:
+  analyze:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: crytic/[email protected]

.gitignore

@@ -2,13 +2,15 @@
 cache/
 out/
 .DS_Store
+docs/
 
 # Ignores development broadcast logs
 /broadcast
 /broadcast/*/31337/
 /broadcast/**/dry-run/
 
-
 # Dotenv file
 .env
 .t
+
+node_modules

.solhint.json

@@ -0,0 +1,20 @@
+{
+  "extends": "solhint:recommended",
+  "rules": {
+    "avoid-low-level-calls": "off",
+    "code-complexity": ["error", 9],
+    "compiler-version": ["error", ">=0.8.0"],
+    "contract-name-camelcase": "off",
+    "const-name-snakecase": "off",
+    "custom-errors": "error",
+    "no-inline-assembly": "off",
+    "func-name-mixedcase": "error",
+    "func-visibility": ["error", { "ignoreConstructors": true }],
+    "max-line-length": ["error", 140],
+    "named-parameters-mapping": "warn",
+    "no-empty-blocks": "off",
+    "not-rely-on-time": "off",
+    "one-contract-per-file": "off",
+    "var-name-mixedcase": "off"
+  }
+}

.solhintignore

@@ -0,0 +1,6 @@
+node_modules/
+test/
+src/integrations/MockRegistry.sol
+src/integrations/examples/
+src/external/examples/
+script/