Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Migration fails when user.id type is 'bigint' #14

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Fix: Migration fails when user.id type is 'bigint' #14

merged 1 commit into from
Jun 17, 2023

Conversation

mtangoo
Copy link
Contributor

@mtangoo mtangoo commented Jun 17, 2023

Migration fails as it tries to call bigint() in postgres. Actual method is bigInteger(). So I just did simple replacement for it to work. Not sure if other databases need such replacement as I do not use them

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues comma-separated list of tickets # fixed by the PR, if any

Migration fails as it tries to call bigint() in postgres. Actual method is bigInteger(). So I just did simple replacement for it to work. Not sure if other databases need such replacement as I do not use them
@rhertogh
Copy link
Owner

Thanks 👍

@rhertogh rhertogh changed the title Fix: Migration fails with Postgres Fix: Migration fails when user.id type is 'bigint' Jun 17, 2023
@rhertogh rhertogh merged commit c8e0761 into rhertogh:master Jun 17, 2023
@rhertogh
Copy link
Owner

For future reference: tinyint and smallint are now also crrectly handled (fbaea5b).

@rhertogh rhertogh added this to the 1.0.0-alpha13 milestone Jun 17, 2023
@rhertogh rhertogh added the bug Something isn't working label Jun 17, 2023
@rhertogh
Copy link
Owner

@mtangoo FYI: Released as 1.0.0-alpha13

@mtangoo
Copy link
Contributor Author

mtangoo commented Jun 19, 2023

@rhertogh am already testing master and is working fine. should I pin to test that release?

@rhertogh
Copy link
Owner

If you were using dev-master before you can continue using that. With the side not that for a production environment it's recommended to specify a specific version.

@mtangoo
Copy link
Contributor Author

mtangoo commented Jun 19, 2023

Yeah was using that, since no stable version is out yet.
The API is not yet deployed for the public so it is not an issue [Yet]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants