FLPATH 1048: Extend software template to offer the CI pipeline (Tekton option) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set default values * Add - to the workflow ID
* Set default values * Add - to the workflow ID
Using forked template
removed dev properties
masayag
reviewed
Mar 5, 2024
| clusterDomain: | ||
| title: Cluster domain | ||
| type: string | ||
| default: cluster-jkrpp.dynamic.redhatworkshops.io |
There was a problem hiding this comment.
no need for a default for this field.
| title: Cluster domain | ||
| type: string | ||
| default: cluster-jkrpp.dynamic.redhatworkshops.io | ||
| description: Cluster domain |
There was a problem hiding this comment.
should we specify in this context this cluster domain is for the tekton pipeline so it won't be mixed with being also the cluster to run the workflows?
There was a problem hiding this comment.
Ok, even if having workflows and tekton on different clusters is something we have never experiment so far (probably the ArgoCD will need its own cluster configuration, in this multi-cluster deployment)
masayag
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tekton(default) andNoneTekton, also generates atektonfolder with the workflow templates to generate the triggering resourcesTekton, also generates a GitHub workflow folder to deploy the resources