Password fixes #94
Merged
Password fixes #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC added and then later removed the diagnostic flag "-Wanalyzer-use-of-uninitialized-value", and so this doesn't work with newer versions of GCC. This patch removes the previous workaround for when it didn't work well. I really wish any of our compilers had any sense of rigor with this stuff at all. Signed-off-by: Peter Jones <[email protected]>
Right now, we have a few callback functions for PK11_Authenticate(), and they take different arguments. This is incorrect; none of the callers ever pass anything through except our CMS context. This fixes get_password_passthrough() to correctly accept the CMS context and get the passthrough data from cms->pwdata instead of trying to treat the CMS context as the pwdata. Related: rhbz#2122777 Signed-off-by: Peter Jones <[email protected]>
Right now, when we read the password/PIN from a file, we're pruning the end of the string from the file we read indiscriminately. If you don't have a newline, that means we're cutting off the final digits of the text. This changes it to prune only common special characters from the pinfile, but also to prune /all/ of them. Related: rhbz#2122777 Signed-off-by: Peter Jones <[email protected]>
frozencemetery
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems I've had related to reading PINs while diagnosing https://bugzilla.redhat.com/show_bug.cgi?id=2122777 .