Upstream all Fedora changes #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the version of the sign API that takes a file type optional, and makes the client attempt to negotiate which version it's getting. It also leaves the server able to still handle the version from before the file type was added. Signed-off-by: Peter Jones <[email protected]> [[email protected]: rebase around error format changes] Signed-off-by: Robbie Harwood <[email protected]>
Signed-off-by: Peter Jones <[email protected]>
Signed-off-by: Peter Jones <[email protected]>
Signed-off-by: Peter Jones <[email protected]>
Signed-off-by: Peter Jones <[email protected]>
Signed-off-by: Peter Jones <[email protected]>
Signed-off-by: Peter Jones <[email protected]> [[email protected]: order of iteration has changed] Signed-off-by: Robbie Harwood <[email protected]>
Signed-off-by: Peter Jones <[email protected]>
Signed-off-by: Peter Jones <[email protected]> [[email protected]: pesign-authorize order changes] Signed-off-by: Robbie Harwood <[email protected]>
authvar.c has a call to free (tokenname) where tokenname is set to a string constant and never changed. That triggers GCC to issue a diagnostic that the value should not be passed to free. This is a false positive from GCC as the call is guarded by a suitable condition that always happens to be false. But pesign is being built without optimization and thus the condition and free call are not optimized away. This patch just disables the warning. A better solution would be to fix the sources or build with the optimizer enabled.
|
At a glance, I think this would close #59. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the changes in the rawhide branch (that I just pushed) which weren't also in main.
The rebases weren't particularly involved, but I'd still feel better with some review.