Feature/visualizer refactor #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhayes777
approved these changes
Apr 15, 2024
Comment on lines
+15
to
+38
| # def test_visualize(): | ||
| # analysis = Analysis() | ||
| # | ||
| # gaussian = af.Model(af.Gaussian) | ||
| # | ||
| # analysis_factor = g.AnalysisFactor( | ||
| # prior_model=gaussian, | ||
| # analysis=analysis | ||
| # ) | ||
| # | ||
| # factor_graph = g.FactorGraphModel( | ||
| # analysis_factor | ||
| # ) | ||
| # | ||
| # model = factor_graph.global_prior_model | ||
| # instance = model.instance_from_prior_medians() | ||
| # | ||
| # factor_graph.visualize( | ||
| # af.DirectoryPaths(), | ||
| # instance, | ||
| # False | ||
| # ) | ||
| # | ||
| # assert analysis.did_call_visualise is True |
| # ) | ||
| # | ||
| # assert analysis_1.did_visualise_combined is True | ||
| # assert analysis_2.did_visualise_combined is False |
There was a problem hiding this comment.
Why did the tests need to be commented?
There was a problem hiding this comment.
The tests are commented because the refactor meant the way the test was designed to make it pass was not working (and I could not figure out how to refactor it).
If you could try get them working again I will then merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small updates to this PR (#993 so other projects can use API as intended.