Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platonify fixes #51

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

platonify fixes #51

wants to merge 5 commits into from

Conversation

rhayes777
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (833821c) 80.71% compared to head (7faf195) 79.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   80.71%   79.62%   -1.10%     
==========================================
  Files          11       11              
  Lines         617      633      +16     
==========================================
+ Hits          498      504       +6     
- Misses        119      129      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

is_section = False
elif is_section and "=" in line:
yield line
elif line.startswith("[") or (is_section and "=" in line):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0_0

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not a good fix!

}


def get_config_with_defaults(i, argument, defaults):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three's a crowd.

@Jammy2211
Copy link
Collaborator

Pretty cool, albeit some wacky changes on detailed inspection!

@rhayes777
Copy link
Owner Author

Pretty cool, albeit some wacky changes on detailed inspection!

Ha yeah I fixed the duplication bug already. Definitely more work required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants