-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platonify fixes #51
base: main
Are you sure you want to change the base?
platonify fixes #51
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 80.71% 79.62% -1.10%
==========================================
Files 11 11
Lines 617 633 +16
==========================================
+ Hits 498 504 +6
- Misses 119 129 +10 ☔ View full report in Codecov by Sentry. |
is_section = False | ||
elif is_section and "=" in line: | ||
yield line | ||
elif line.startswith("[") or (is_section and "=" in line): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0_0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not a good fix!
} | ||
|
||
|
||
def get_config_with_defaults(i, argument, defaults): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three's a crowd.
Pretty cool, albeit some wacky changes on detailed inspection! |
Ha yeah I fixed the duplication bug already. Definitely more work required |
No description provided.