Build more wheels #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindwe
commented
Jul 17, 2024
| matrix: | ||
| arch: [aarch64, armhf, armv7, amd64, i386] |
There was a problem hiding this comment.
arch does not have any effect in the old version, except triggering 5 identical jobs.
oyvindwe
commented
Jul 17, 2024
| @@ -31,47 +39,3 @@ jobs: | |||
| run: | | |||
| .venv/bin/pip3 install pytest | |||
| .venv/bin/pytest -vv tests | |||
| test_macos: | |||
There was a problem hiding this comment.
The steps are identical with test_linux, so I merged the jobs.
- actions/create-release@v1 -> ncipollo/release-action@v1 - actions/upload-release-asset@v1 -> svenstaro/upload-release-action@v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build wheels for:
cp311-cp311-macosx_10_9_universal2cp312-cp312-macosx_10_9_universal2cp312-cp312-macosx_14_0_arm64cp311-cp311-linux_x86_64cp312-cp312-linux_x86_64Merged linux and macos jobs, as they can be controlled by the matrix.
Removed arch from the linux job, as it did not build on different architectures
See https://github.com/oyvindwe/webrtc-noise-gain/actions/runs/9981161290 for a run of the
testworkflow.Also updated release actions to fix warnings. See https://github.com/oyvindwe/webrtc-noise-gain/actions/runs/10008601807 of a run of the
wheelsworkflow with the result here: https://github.com/oyvindwe/webrtc-noise-gain/releases/tag/test-release-4