Fix version of numpy expected by networkx #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rhasspy-remote-http-hermes uses networkx==2.4 which uses numpy.int:
https://github.com/networkx/networkx/blob/networkx-2.4/networkx/readwrite/graphml.py#L346
This was deprecated in newer version of numpy. Instead of upgrading, which I am not qualified to do with my limited python experience, I am fixing the numpy version as what is expected throughout rhasspy to 1.20.1:
https://github.com/rhasspy/rhasspy/blob/0b6caab2ea41f022fa4d8c0714ad00befcbb38d2/Dockerfile#L150
I will do this in other submodules if this gets approved to make the instructions for virtual environment work:
https://rhasspy.readthedocs.io/en/latest/installation/#virtual-environment
There is a similar need to fix the markupsafe transitive dependency to version 2.0.1.