-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPENJDK-2735] Move grep and gawk installation to phase-1 #472
Conversation
Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@@ -29,7 +29,15 @@ objects: | |||
dockerfile: | | |||
FROM - | |||
USER 0 | |||
RUN microdnf --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install -y java-${JDK_VERSION}-openjdk-jmods | |||
RUN mkdir -p /mnt/jrootfs | |||
RUN microdnf install --installroot /mnt/jrootfs --releasever 9 --setopt install_weak_deps=0 --nodocs -y java-${JDK_VERSION}-openjdk-jmods \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need the jmods RPM content to be in the final image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then I retain the original line and add the remaining stuff necessary for /mnt/jrootfs after the original line for jmods RPM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great -- that puts jmods back into the builder
I hit this regularly with CRC. I would like to find a way to increase the amount of storage it has.
This hasn't worked for me either. When I hit this issue I have ot blow away the whole cluster and start a fresh ( It looks like passing |
Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@@ -29,6 +29,7 @@ objects: | |||
dockerfile: | | |||
FROM - | |||
USER 0 | |||
RUN microdnf --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install -y java-${JDK_VERSION}-openjdk-jmods | |||
RUN mkdir -p /mnt/jrootfs | |||
RUN microdnf install --installroot /mnt/jrootfs --releasever 9 --setopt install_weak_deps=0 --nodocs -y java-${JDK_VERSION}-openjdk-jmods \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is still installing the jmods RPM into the jrootfs directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry :( copy paste mistake.
Signed-off-by: Jayashree Huttanagoudar <[email protected]>
In my case even stop and start didnt work :D
That will help. |
As suggested I have made an attempt to move
grep
andgawk
installation to phase-1.But with or without this change my builds are coming out with
When I tried to check on web console as
adminstrator
I see that it is some ephemeral-storage issue.I deleted all builds/pods/imagestreams but there is no effect :)
Yesterday I was trying to create a deployment which was continuously failing and creating successive pods after every failure. I guessed that might have consumed all the memory and deleted all pods in that project. Now on local CRC I don't have any builds. Even then builds are failing with that
cri-o error
.