Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-2735] Move grep and gawk installation to phase-1 #472

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

jhuttana
Copy link
Contributor

@jhuttana jhuttana commented Apr 2, 2024

As suggested I have made an attempt to move grep and gawk installation to phase-1.
But with or without this change my builds are coming out with

unable to retrieve container logs for cri-o:.........

When I tried to check on web console as adminstrator I see that it is some ephemeral-storage issue.

Generated from kubelet on crc-vlf7c-master-0
The node was low on resource: ephemeral-storage. Threshold quantity: 4902142351, available: 4730208Ki. Container docker-build was using 4Ki, request is 0, has larger consumption of ephemeral-storage

I deleted all builds/pods/imagestreams but there is no effect :)
Yesterday I was trying to create a deployment which was continuously failing and creating successive pods after every failure. I guessed that might have consumed all the memory and deleted all pods in that project. Now on local CRC I don't have any builds. Even then builds are failing with that cri-o error.

Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@jhuttana jhuttana requested review from jmtd and Josh-Matsuoka April 2, 2024 09:24
@@ -29,7 +29,15 @@ objects:
dockerfile: |
FROM -
USER 0
RUN microdnf --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install -y java-${JDK_VERSION}-openjdk-jmods
RUN mkdir -p /mnt/jrootfs
RUN microdnf install --installroot /mnt/jrootfs --releasever 9 --setopt install_weak_deps=0 --nodocs -y java-${JDK_VERSION}-openjdk-jmods \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need the jmods RPM content to be in the final image.

Copy link
Contributor Author

@jhuttana jhuttana Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then I retain the original line and add the remaining stuff necessary for /mnt/jrootfs after the original line for jmods RPM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great -- that puts jmods back into the builder

@jmtd
Copy link
Member

jmtd commented Apr 2, 2024

When I tried to check on web console as adminstrator I see that it is some ephemeral-storage issue.

I hit this regularly with CRC. I would like to find a way to increase the amount of storage it has.

I deleted all builds/pods/imagestreams but there is no effect :)

This hasn't worked for me either. When I hit this issue I have ot blow away the whole cluster and start a fresh (crc delete, crc start)

It looks like passing -d (Total size in GiB of the disk used by the instance (default 31)) to crc start will create a bigger disk.

Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@@ -29,6 +29,7 @@ objects:
dockerfile: |
FROM -
USER 0
RUN microdnf --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install -y java-${JDK_VERSION}-openjdk-jmods
RUN mkdir -p /mnt/jrootfs
RUN microdnf install --installroot /mnt/jrootfs --releasever 9 --setopt install_weak_deps=0 --nodocs -y java-${JDK_VERSION}-openjdk-jmods \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is still installing the jmods RPM into the jrootfs directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry :( copy paste mistake.

Signed-off-by: Jayashree Huttanagoudar <[email protected]>
@jhuttana
Copy link
Contributor Author

jhuttana commented Apr 2, 2024

When I tried to check on web console as adminstrator I see that it is some ephemeral-storage issue.

I hit this regularly with CRC. I would like to find a way to increase the amount of storage it has.

I deleted all builds/pods/imagestreams but there is no effect :)

This hasn't worked for me either. When I hit this issue I have ot blow away the whole cluster and start a fresh (crc delete, crc start)

In my case even stop and start didnt work :D
I just reconfigured crc and then it worked.

It looks like passing -d (Total size in GiB of the disk used by the instance (default 31)) to crc start will create a bigger disk.

That will help.

@jmtd jmtd merged commit a859973 into rh-openjdk:jlink-dev Apr 2, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants