[OPENJDK-2686] Jlink stage 1 - BuildConfig and Imagestream for creating a builder image with the jmods rpm installed #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to run a build on each in an openshift environment
|
Runtime GHA test failures are likely unrelated to this PR and due to the issue under #455. |
jmtd
reviewed
Feb 28, 2024
jmtd
reviewed
Feb 28, 2024
jmtd
reviewed
Feb 28, 2024
jmtd
reviewed
Feb 28, 2024
jmtd
reviewed
Feb 28, 2024
|
I think we should add a dependency on an OpenJDK imageStream, the problem is we don't provide any UBI9 ones yet. We provide
I've filed https://issues.redhat.com/browse/OPENJDK-2811 to get some added. In the meantime we should probably add a rudimentary one to this branch; I've filed https://issues.redhat.com/browse/OPENJDK-2812 for that. |
jmtd
reviewed
Mar 15, 2024
jmtd
reviewed
Mar 20, 2024
jmtd
reviewed
Mar 20, 2024
jmtd
reviewed
Mar 20, 2024
jmtd
reviewed
Mar 20, 2024
jmtd
reviewed
Mar 20, 2024
|
This is awesome! |
jmtd
reviewed
Mar 20, 2024
jmtd
reviewed
Mar 20, 2024
jmtd
reviewed
Mar 20, 2024
jmtd
reviewed
Mar 20, 2024
Signed-off-by: Jonathan Dowland <[email protected]>
In particular explicit namespace references Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
I think it's slightly clearer (to a human) to see the template's parameters prior to the objects into which they are interpolated. Signed-off-by: Jonathan Dowland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses stage 1 of the planned multi-stage jlink build
The script currently works off of a local crc instance (getting oc from crc oc-env), this can probably be generalized later if needed but for local testing it should do the trick. Requires you to be logged into the crc environment (i,e, having run oc login)