Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-2428] Test coverage for user-provided run-env.sh and Update test URI to refer new application source repo #420

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

jhuttana
Copy link
Contributor

JIRA tracker: https://issues.redhat.com/browse/OPENJDK-2428

This PR includes test coverage for user-provided run-env.sh and Update test URI to refer new application source repository which are already been merged to ubi9.

I have tested the changes locally and they passed.

$ cekit --descriptor ubi8-openjdk-17.yaml test behave --wip
.
.
.
.
  @ubi8 @wip
  Scenario: Check non-existent path JAVA_APP_DIR (OPENJDK-2033)                                   # features/image/java/runtime.feature:91
    Given container is started with env                                                           # steps/container_steps.py:72 10.510s
      | variable     | value |
      | JAVA_APP_DIR | /nope |
    Then available container log should contain ERROR No directory /nope found for auto detection # steps/container_steps.py:50
    Then available container log should contain ERROR No directory /nope found for auto detection # steps/container_steps.py:50 0.006she logs
2023-11-23 14:48:30,936 container.py:100        INFO  Removing container 'c588934f1c7f62626d23bcc9a5047c0e94382638275e38cd1b69710c11fb3f26', 1 try...
2023-11-23 14:48:30,961 container.py:103        INFO  Container 'c588934f1c7f62626d23bcc9a5047c0e94382638275e38cd1b69710c11fb3f26' removed

8 features passed, 0 failed, 7 skipped
58 scenarios passed, 0 failed, 48 skipped
168 steps passed, 0 failed, 144 skipped, 0 undefined
Took 72m2.960s
2023-11-23 14:48:30,965 cli.py:503        INFO  Finished!

@jhuttana jhuttana requested a review from jmtd November 23, 2023 09:58
@jmtd
Copy link
Member

jmtd commented Nov 23, 2023

Thank you. I'm running the test suite now, but I don't expect problems. THere are a couple of tests that still reference the old URI -- these might not have been in the ubi9 branch, I'm not sure:

;git grep jboss-openshift -- tests/features
tests/features/java/java_s2i.feature:    Given failing s2i build https://github.com/jboss-openshift/openshift-examples from spring-boot-sample-simple using openjdk-enforce-profile
tests/features/jolokia.feature:    Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
tests/features/jolokia.feature:    Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
tests/features/jolokia.feature:    Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet

Please convert them over in an additional commit. Thanks!

@jmtd
Copy link
Member

jmtd commented Nov 23, 2023

Tests all pass locally except one but that's another issue (OPENJDK-2438)

@jmtd jmtd merged commit 6934255 into rh-openjdk:ubi8 Nov 27, 2023
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants