Added testcase to check if tar is installed in the container image. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judovana
reviewed
Mar 8, 2024
| # This test is added to check that tar is installed in all Openjdk images. | ||
| # https://issues.redhat.com/browse/OPENJDK-2588 | ||
| function testTarIsInstalled() { | ||
| runOnBaseDir tar --version |
There was a problem hiding this comment.
in very extreme cases (eg messed up security release of tar), the --version may not be enough , and rpm -q tar . But thats just an idea forfuture far far away. ty!
judovana
approved these changes
Mar 8, 2024
jmtd
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcase to test the presents of 'tar' in the container image.
Related to ticket: https://issues.redhat.com/browse/OPENJDK-2588
Ran locally against a full image, an old runtime image to prove it fails and the current runtime image to prove it passes.