[OPENJDK-1966] October CPU updates. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o update version check for Oct CPU Java versions.
andrlos
approved these changes
Oct 13, 2023
|
LGTM, as this is not a big change, all the versions seem to be correct |
judovana
reviewed
Oct 15, 2023
| # #echo | ||
| # echo "rhel8 repos not added" | ||
| # #unluckily, config-manager is notworking, removing nodejs from the project itself rather | ||
| # elif [ `getOsMajor` -eq 7 ] ; then |
There was a problem hiding this comment.
Although th https://github.com/rh-openjdk/jdkContainerOsTests/pull/2/files#diff-d4159e621004e9e44da852177057b68c20db675d533dffc305a479f199c911bfR79 is a bit explaining, maybe it hsould be separate commit with deeper expalanation
judovana
reviewed
Oct 15, 2023
| JRE_17_VERSION='17.0.8+7-LTS' | ||
| JRE_8_VERSION='1.8.0_392-b08' | ||
| JRE_11_VERSION='11.0.21+9-LTS' | ||
| JRE_17_VERSION='17.0.9+9-LTS' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the testlib file to not run the base image test on RHEL 7 systems due to lack of support by Podman 1.6.x for the version 2 schema.
Updated version numbers of Java for the October CPU.
Removed code that should not be in there.