Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destiny Bond fails on repeated use in Gen 7+ #5652

Open
wants to merge 7 commits into
base: upcoming
Choose a base branch
from

Conversation

Pawkkie
Copy link
Collaborator

@Pawkkie Pawkkie commented Nov 8, 2024

Description

Destiny Bond fails if used multiple turns in a row from Gen 7 onwards

https://bulbapedia.bulbagarden.net/wiki/Destiny_Bond_(move)

Issue(s) that this PR fixes

#5651

People who collaborated with me in this PR

freezai for the idea!

Discord contact info

@Pawkkie

@Pawkkie Pawkkie added category: battle-mechanic Pertains to battle mechanics new-feature Adds a feature labels Nov 8, 2024
@hedara90
Copy link
Collaborator

hedara90 commented Nov 8, 2024

Shouldn't Destiny Bond be able to be used if something is used in-between Destiny Bond usages?
Battler goes: Destiny Bond (Success) -> Tackle -> Destiny Bond (Success)
But right not it goes: Destiny Bond (Success) -> Tackle -> Destiny Bond (Fail)

E: I don't know how it's supposed to interact if the battler gets flinched, has truant or is otherwise prevented from moving.

@Pawkkie
Copy link
Collaborator Author

Pawkkie commented Nov 8, 2024

Shouldn't Destiny Bond be able to be used if something is used in-between Destiny Bond usages? Battler goes: Destiny Bond (Success) -> Tackle -> Destiny Bond (Success) But right not it goes: Destiny Bond (Success) -> Tackle -> Destiny Bond (Fail)

E: I don't know how it's supposed to interact if the battler gets flinched, has truant or is otherwise prevented from moving.

LOL this is what I get for jamming in a feature between meetings.

I'll address once I'm actually done for the day and on the other side of dinner :)

@AlexOn1ine
Copy link
Collaborator

Shouldn't Destiny Bond be able to be used if something is used in-between Destiny Bond usages? Battler goes: Destiny Bond (Success) -> Tackle -> Destiny Bond (Success) But right not it goes: Destiny Bond (Success) -> Tackle -> Destiny Bond (Fail)
E: I don't know how it's supposed to interact if the battler gets flinched, has truant or is otherwise prevented from moving.

LOL this is what I get for jamming in a feature between meetings.

I'll address once I'm actually done for the day and on the other side of dinner :)

In this case maybe use LastLandedMoves? You also don't need the new field in this case.

@Pawkkie
Copy link
Collaborator Author

Pawkkie commented Nov 9, 2024

In this case maybe use LastLandedMoves? You also don't need the new field in this case.

This was a sick idea that didn't work, but gLastResultingMoves did what we wanted gLastLandedMoves to do and cleaned it up very nicely :)

The difference between those two fields is not entirely clear to me lol

Fixed!

@Pawkkie Pawkkie added this to the 1.11 milestone Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: battle-mechanic Pertains to battle mechanics new-feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants