Non-schedulable nodes should not be part of targeted nodes for Module… #83
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @ybettan |
…rh-ecosystem-edge#125) Currently ModuleLoader cannot be scheduled to run on Non-Schedulable nodes, i.e. masters etc'. This PR fixed the extraction of schedulable nodes list, which will also affect the status update of the Module
yevgeny-shnaidman
force-pushed
the
yevgeny/cherry-pick-c26cefd073c238b4fe0bf85a814594d3cdbee0b4
branch
from
f81d24a to
c13ee41
Compare
|
Upstream PR for cherry-pick: |
| logger.Error(err, "Could not list nodes") | ||
| return nil, fmt.Errorf("could not list nodes: %v", err) | ||
| } | ||
| return nodes.Items, nil | ||
| nodes := make([]v1.Node, 0, len(selectedNodes.Items)) |
There was a problem hiding this comment.
I would prefer to call it scheduableNodes but let's stay consistent with the u/s code.
| @@ -397,3 +404,12 @@ func (r *ModuleReconciler) SetupWithManager(mgr ctrl.Manager, kernelLabel string | |||
| Named("module"). | |||
| Complete(r) | |||
| } | |||
|
|
|||
| func isNodeSchedulable(node *v1.Node) bool { | |||
| for _, taint := range node.Spec.Taints { | |||
There was a problem hiding this comment.
Who is responsible for tainting the node?
There was a problem hiding this comment.
master nodes , that are not schedulable ( not SNO) are tainted by KubeAPI server
There was a problem hiding this comment.
Ack. So this has nothing to do with our code.
|
/lgtm |
… (#125)
Currently ModuleLoader cannot be scheduled to run on Non-Schedulable nodes, i.e. masters etc'. This PR fixed the extraction of schedulable nodes list, which will also affect the status update of the Module