Implement pre-forking on Unix #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmattio
force-pushed
the
pre-fork
branch
2 times, most recently
from
65f11f9
to
ed4d7e7
Compare
tmattio
added a commit
to tmattio/opam-repository
that referenced
this pull request
Dec 9, 2020
CHANGES: ## Added - New `Auth` module to work with `Authorization` header (rgrinberg/opium#238) - New `basic_auth` middleware to protect handlers with a `Basic` authentication method (rgrinberg/opium#238) - New `Response.of_file` API for conveniently creating a response of a file (rgrinberg/opium#244) - Add a package `opium-graphql` to easily create GraphQL server with Opium (rgrinberg/opium#235) - Add a function `App.run_multicore` that uses pre-forking and spawns multiple processes that will handle incoming requests (rgrinberg/opium#239) ## Fixed - Fix reading cookie values when multiple cookies are present in `Cookie` header (rgrinberg/opium#246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR borrows code from https://github.com/TechEmpower/FrameworkBenchmarks/tree/master/frameworks/OCaml/opium/src that forks the process to spawn multiple instances of the Opium app.
The Opium command line now provides a
-j/--jobsargument to set the number of instances that will be spawn. It defaults to the number of cores on the host machine on Unix, and 1 on Windows.Since we cannot nest calls to
Lwt_main.runand to offer a unified API for multicore and single core, we lose the ability to return anLwt.tfrom the run functions. But maybe there's another way to implement that I'm not seeing.cc @mudrz
Fixes #222
Closes #207