Expose a push function for streams #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second attempt at supporting streams. Instead of exposing the underlying type, expose an api which gives the user a push function where they can push strings.
anuragsoni
added a commit
to anuragsoni/opam-repository
that referenced
this pull request
Mar 25, 2020
CHANGES: * Make examples easier to find and add documentation related to features used in them. (rgrinberg/opium#125, @shonfeder) * Allow overriding 404 handlers (rgrinberg/opium#127, @anuragsoni) * Support cohttp streaming response (rgrinberg/opium#135, rgrinberg/opium#137, rgrinberg/opium#139, @anuragsoni)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at supporting streams. Instead of exposing
the underlying type, expose an api which gives the user
a push function where they can push strings.