wgetopt variable for general used wget options #214
Conversation
|
Thanks for the contribution. I want to say there was a reason I didn't do this initially but I can not recall it offhand, so it couldn't have been very compelling.... I will review this when time permits in coming days and commit for a quick 1.6.1 release I need to put out to address some smaller items. |
|
I stumbled upon this when looking into the possibilities to replace wget with curl. But this task needs a bit more work I think. |
files/internals/internals.conf
Outdated
| @@ -27,6 +27,7 @@ wget_retries="3" | |||
| wget_proxy="" | |||
|
|
|||
| wget=`which wget 2> /dev/null` | |||
| wgetopt=`-e http_proxy="$wget_proxy" -e https_proxy="$wget_proxy" -T$wget_timeout -t$wget_retries -q` | |||
There was a problem hiding this comment.
wgetopt= is defined with backticks = will try run as a command instead of defining as a variable
Can you fix this up? Thanks
There was a problem hiding this comment.
Sorry ... that slipped somehow through. I've converted them into single quotes.
Makes it easier to change (and replace) wget options at a unique place.
|
I pushed an updated commit. I'm not able to assign the PR back to you @rfxn |
Makes it easier to change (and replace) wget options at a unique place.