Resource loading from classpath

[dayenda]

In the ResourceUtil class, classpath resource are loaded using ClassLoader.getSystemClassLoader(). This works fine when running from an IDE, but its giving me issues when running from a Spring Boot fat jar.

Is it possible to delegate resource loading to a child class loader (the spring boot class loader in my case), or could it make sense to use the current class loader instead of system class loader in ResourceUtil?

[rfoltyns]

What sort of issues are you having?
Where's the resource you're trying to load? Is it a resource of your Spring Boot app or is it a part of your app's dependencies?
Have you tried the solution used in log4j2-elasticsearch-hc-springboot?
Could you post your configuration, please?

[rfoltyns]

as an extension to log4j2, I would expect the resource loading to follow the same logic

Even though it's an extension to Log4j2, it's only the ElasticsearchAppender, Log4j2 plugins and handful of other classes that should depend on it. Decoupling process is slowly happening since the last few months. As of 2.0, most of the code will be moved to appenders repos (including ResourceUtil). Appender, layout and plugins will be the only remaining classes.

simply delegate to org.apache.logging.log4j.core.util.Loader::getResourceAsStream(String, ClassLoader)

Given the plans mentioned above, ResourceUtil cannot depend on any Log4j2 classes.

A small, private ResourceUtil.getClassLoaders() method with a list of system class loader and thread class loader should be enough here. Find in classloaders -> break and load if found -> throw if not found.

[dayenda]

I have created PR: #67

[rfoltyns]

Thanks 👍 Have a look at the changes I've added and let me know what you think.

[dayenda]

Thanks for your help 😊

[rfoltyns]

You're welcome! Happy to help! 🙂