Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build script to use GOFLAGS and CGO_LDFLAGS #460

Closed
wants to merge 3 commits into from
Closed

Update build script to use GOFLAGS and CGO_LDFLAGS #460

wants to merge 3 commits into from

Commits on Mar 15, 2020

  1. Update build script to use GOFLAGS and CGO_LDFLAGS 

    This change makes use of GOFLAGS to simplify compiling with PIE, respecting LDFLAGS and trimming local paths to support reproducible builds.

Relevant: https://lists.archlinux.org/pipermail/arch-dev-public/2020-March/029898.html

Since you are already providing a source tarball that includes vendor dependencies (👍), all dependency-related items in the email do not apply to you:

* -mod=vendor is used by default in Go 1.14
* -modcacherw is only needed if our build system was fetching vendor dependencies itself

Tested by applying this patch on top of 1.7.1 release archive that contains vendor folder.
    @maximbaz
    maximbaz committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    8c34f54 View commit details
    Browse the repository at this point in the history

  2. Allow to override default values from outside, if necessary

    @maximbaz
    maximbaz committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    a29b6f5 View commit details
    Browse the repository at this point in the history

  3. Fix when LDFLAGS is unbound

    @maximbaz
    maximbaz committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    f195449 View commit details
    Browse the repository at this point in the history