Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In reverse mode, gocrypt.longname.*.name files are not properly excluded with the "-exclude" option #286

Closed
slackner opened this issue Dec 17, 2018 · 2 comments
Closed

In reverse mode, gocrypt.longname.*.name files are not properly excluded with the "-exclude" option #286

slackner opened this issue Dec 17, 2018 · 2 comments
Labels
bug

Comments

@slackner
Copy link
Contributor

Steps to reproduce:

mkdir local remote
gocryptfs -init  -reverse local
touch local/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
gocryptfs -reverse -exclude AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA local remote

While the actual file is properly excluded, the * .name file is still leaked in the directory listing:

drwxr-xr-x 2 sebastian sebastian 4,0K Dez 17 14:58 .
drwxr-xr-x 7 sebastian sebastian 4,0K Dez 17 14:45 ..
-r-------- 1 sebastian sebastian  408 Dez 17 14:56 gocryptfs.conf
-r--r--r-- 1 sebastian sebastian   16 Dez 17 14:58 gocryptfs.diriv
-r--r--r-- 1 sebastian sebastian  320 Dez 17 14:58 gocryptfs.longname.3vZ_r3eDPb1_fL3j5VA4rd_bcKWLKT9eaxOVIGK5HFA.name
@rfjakob
Copy link
Owner

rfjakob commented Dec 24, 2018

Good find, will fix, thanks!

@rfjakob rfjakob added the bug label Dec 27, 2018
rfjakob added a commit that referenced this issue Jan 4, 2019
@rfjakob
tests: reverse: verify that longname .name files are exluded as well
58f62ad 
Currently fails, will be fixed in the next commit.

#286
@rfjakob rfjakob closed this as completed in 6b94f5e Jan 4, 2019
@rfjakob
Copy link
Owner

rfjakob commented Jan 4, 2019

Tests fixed, and bug fixed as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfjakob @slackner