Support Generically Typed Implementations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezonant
reviewed
Mar 19, 2022
dwelch2344
commented
Mar 21, 2022
| @@ -21,7 +21,8 @@ | |||
| "mock" | |||
| ], | |||
| "dependencies": { | |||
| "typescript-rtti": "^0.4.16" | |||
| "deep-equal": "^2.0.5", | |||
There was a problem hiding this comment.
Think I don't need this here
|
|
||
| // if it's a generic ref, lookup the specific match we put in the map | ||
| if( token instanceof ReflectedGenericRef && token.isGeneric()){ | ||
| token = this.#generics.find(t => t.matchesRef(token)) || token |
There was a problem hiding this comment.
Assuming matchesRef(..) works out, we can essentially resolve the token here with a simple list of generic tokens, then let things play out as normal :)
| @@ -206,6 +223,9 @@ export class Injector { | |||
| return { tokens: [ typeRef.token ] }; | |||
| else if (typeRef.isLiteral()) | |||
| return { tokens: [ typeRef.value.constructor ]} | |||
| else if (typeRef.isGeneric() ) | |||
| // TODO: ask @rezonant for a better way to handle this | |||
| return { tokens: [ typeRef ]} | |||
There was a problem hiding this comment.
Thinking this is good now. Essentially we support the ref itself as an actual token (and presume our token resolution will unify different instances)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought us up to the 0.5.0 cut of rtti, and added a first stab at supporting generic tokens.
Probably a much smarter way of both creating the provider + resolving the tokens, but I was able to "break all teh tests" and then repair them with this simple approach.
Def open to feedback. But it's working on my use case really nicely, so gives me hope :)