Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system tests were failing both locally and in CI, with this error (newlines added for readability):
This was caused by changed in Google hosting and API changes, which were not picked up by the
webdrivers
gem 1. This gem's functionality has now been included inselenium-webdriver
, so updating it and removingwebdrivers
fixes this issue.However we then hit another issue:
ArgumentError: wrong number of arguments (given 2, expected 0..1)
, caused by a change inselenium-webdriver
which brokecapybara
2. It was fixed in 3.39.1.We had then another error:
unknown keyword: :capabilities
3. This was fixed in Railsactionpack
7.0.5.This PR removes
webdrivers
from the Gemfile, updatesselenium-webdriver
andcapybara
to the latest version, and updates Rails to the latest 7.0.x (staying on the same minor version to have the least amount of changes).This was done by updating the
Gemfile
manually, then runningbundle update rails selenium-webdrivers capybara
.Finally, the fix on the CI workflow should have been caught in #436 but tests were failing then, so it's fixed here (the codecov action needs an Actions Workflow permission to generate a GitHub OIDC token).
Footnotes
https://github.com/titusfortner/webdrivers/issues/247#issuecomment-1641139415 ↩
https://github.com/teamcapybara/capybara/issues/2666 ↩
https://github.com/rails/rails/releases/tag/v7.0.5 ↩