-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔒 Generic Oauth installer #1150
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi 👋 Here's a preview environment 🚀 https://next-reworkd-agentgpt-1150.env.ergomake.link Environment Summary 📑
Here are your environment's logs. For questions or comments, join Discord. Click here to disable Ergomake. |
id String @id @default(cuid()) | ||
user_id String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to be more specific with id? is it an account identifier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, it maps directly to the user table :)
pytest is failing - |
# Conflicts: # platform/poetry.lock
provider String | ||
token_type String | ||
access_token String | ||
scope String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this typically work. As in, do all oauth systems typically use a string to define scope? How will we deal with scopes that require a list of strings
) -> str: | ||
"""Install an OAuth App""" | ||
url = await installer.install(user) | ||
print(url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: print
crud = mocker.Mock() | ||
|
||
with pytest.raises(NotImplementedError): | ||
installer_factory("asim", crud) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤨
# Settings for slack | ||
slack_client_id: str = "" | ||
slack_client_secret: str = "" | ||
slack_redirect_uri: str = "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in the DB now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is for our app, we are installing our app into other peoples slack
from sqlalchemy.ext.asyncio import AsyncSession | ||
|
||
T = TypeVar("T", bound="BaseCrud") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
We should probably encrypt the access tokens in the database, that can be future