Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Vietnamese translation #1650

Merged
merged 1 commit into from
May 20, 2023
Merged

Added Vietnamese translation #1650

merged 1 commit into from
May 20, 2023

Conversation

MinatoIsuki
Copy link
Contributor

What I've done:

  • Added Vietnamese to AVR_Miner, CLI_Wallet, PC_Miner, Wallet and Readme.
    I'm just a beginner at Github and coding so if there's any mistake, please let me know!

@MinatoIsuki MinatoIsuki mentioned this pull request May 14, 2023
Open
@Tech1k Tech1k self-assigned this May 15, 2023
@Tech1k Tech1k added the translations Language translations label May 15, 2023
Tech1k
Tech1k requested changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@Tech1k Tech1k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JustSomeRandomGuy3!

Welcome to Github and thank you for contributing to the Duino-Coin project! Your changes look good, but could you squash your commits into a single one? Here is a fairly easy tutorial on how to do that: https://www.git-tower.com/learn/git/faq/git-squash

Let me know if you have any questions!

@MinatoIsuki
Copy link
Contributor Author

MinatoIsuki commented May 15, 2023 •
edited
Loading

Hello @Tech1k,

Thank you for viewing my PR, but, after I read the website, should I...

  1. Close this PR and an administrator will squash and merge it

Or...

  1. Just squash it from Github Desktop (I'm currently away from my laptop)

To squash all commit to one? I'm just a beginner and this is my first PR so I don't have any idea how this works yet. If there is another way, please let me know!

EDIT: Forget it.

@MinatoIsuki
Copy link
Contributor Author

MinatoIsuki commented May 15, 2023 •
edited
Loading

That should do the job.

@MinatoIsuki MinatoIsuki requested a review from Tech1k May 20, 2023 07:54
@Tech1k
Copy link
Collaborator

Tech1k commented May 20, 2023 •
edited
Loading

It seems that I might be able to merge this pr while squashing all the commits on my side, let me check.

@Tech1k Tech1k merged commit 847e514 into revoxhere:master May 20, 2023
@Tech1k
Copy link
Collaborator

Tech1k commented May 20, 2023

Thank you for your contribution to Duino-Coin!

@revoxhere revoxhere mentioned this pull request May 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tech1k Tech1k Tech1k approved these changes

Assignees

@Tech1k Tech1k

Labels
translations Language translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MinatoIsuki @Tech1k