Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_mode: change default from added to file #25

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

Slamdunk
Copy link
Contributor

Hi, I was hit hard by the default setting filder_mode: added: a developer of ours removed a line, the producion broke but the Github Action passed.

I propose here to have file as the default method: it's equally fast and doesn't miss such critical cases.

@Slamdunk
Copy link
Contributor Author

Any feedback @haya14busa ?

@grische
Copy link
Contributor

grische commented Nov 11, 2021

I have encountered the same problem, someone deleting the initialization of a variable, breaking all references later in the script.
For now, I manually added filter_mode: file to all action-shellcheck everywhere, but it would be great to have it as a default.

@Slamdunk There seem to be some conflicts with your PR.

@Slamdunk
Copy link
Contributor Author

@grische thank you for the notice, PR was ok when I opened it 2 months ago.

Maybe @shogo82148 can review and merge this 🤞

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shogo82148 shogo82148 merged commit 2c31bf1 into reviewdog:master Nov 13, 2021
@review-dog
Copy link
Member

Hi, @Slamdunk! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

@Slamdunk Slamdunk deleted the filter_mode_file branch November 13, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants