Merge pull request #54 from reviewdog/fix-reporter

Fix reporter input and change the default reporter for suggestion
reviewdog · Oct 26, 2020 · 73296c9 · 73296c9
2 parents 625477c + 84380e6
commit 73296c9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -27,7 +27,7 @@ It's same as `-level` flag of reviewdog.
 ### `reporter`
 
 Reporter of reviewdog command [github-pr-check,github-check,github-pr-review].
-Default is github-pr-check.
+Default is github-pr-review.
 It's same as `-reporter` flag of reviewdog.
 
 github-pr-review can use Markdown and add a link to rule page in reviewdog reports.

diff --git a/action.yml b/action.yml
@@ -11,10 +11,10 @@ inputs:
     default: 'error'
   reporter:
     description: |
-      Reporter of reviewdog command [github-pr-check,github-pr-review].
-      Default is github-pr-check.
+      Reporter of reviewdog command [github-check,github-pr-review].
+      Default is github-pr-review.
       github-pr-review can use Markdown and add a link to rule page in reviewdog reports.
-    default: 'github-pr-check'
+    default: 'github-pr-review'
   filter_mode:
     description: |
       Filtering mode for the reviewdog command [added,diff_context,file,nofilter].

diff --git a/entrypoint.sh b/entrypoint.sh
@@ -14,7 +14,7 @@ $(npm bin)/eslint --version
 $(npm bin)/eslint -f="${ESLINT_FORMATTER}" ${INPUT_ESLINT_FLAGS:-'.'} \
   | reviewdog -f=rdjson \
       -name="${INPUT_TOOL_NAME}" \
-      -reporter=github-pr-review \
+      -reporter="${INPUT_REPORTER:-github-pr-review}" \
       -filter-mode="${INPUT_FILTER_MODE}" \
       -fail-on-error="${INPUT_FAIL_ON_ERROR}" \
       -level="${INPUT_LEVEL}" \

diff --git a/test-subproject/sub-testdata/test.js b/test-subproject/sub-testdata/test.js
@@ -1,4 +1,4 @@
 function test() {
-  for (var i = 0; i < 11; i--) {
+  for (var i = 0; i < 10; i--) {
   }
 }