Add support tag checker #33
Conversation
entrypoint.sh
Outdated
| jq -r '.[] | .tag_name' | \ | ||
| grep -oP '\d+\.\d+(\.\d+)?(-[^'\''\"\s]*)?$' | \ | ||
| list_versions | \ | ||
| grep -oP '\d+\.\d+(\.\d+)*(-[^'\''\"\s]*)?$' | \ |
There was a problem hiding this comment.
oh, wait. I noticed that you changed the regex too.
Can you revert the change or explain why you updated the regex?
There was a problem hiding this comment.
Why
Some tags have been given a small version that deviates from the rules of semver, so I changed it.
Validity of change
Because, previouse commit split release(semver valid) and tag (semver deviate).
First, I think non-semver ruling tag(x.y.z.?) ignoring rule...but test case support non-semver(for -hoge suffix).
And I tried to support it.
There was a problem hiding this comment.
Hmm... I guess I don't get it. Can you list actual real-world examples who uses x.y.z.??
Also, this repo doesn't intend to support non-semver in the first place, so can you propose a change separately?
There was a problem hiding this comment.
Note that -xyz suffix is actually valid semver. https://semver.org/#spec-item-10
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, I get it. Hmm... 1.5.2.1 is a super weird tag name...
Ideally, I'd reject such inputs, but maybe it's fine to accept. I left a suggestion to make the regex simpler but LGTM other than that.
There was a problem hiding this comment.
Agree.
x.y.z.a ... can be simply drop away.
entrypoint.sh
Outdated
| jq -r '.[] | .tag_name' | \ | ||
| grep -oP '\d+\.\d+(\.\d+)?(-[^'\''\"\s]*)?$' | \ | ||
| list_versions | \ | ||
| grep -oP '\d+\.\d+(\.\d+)*(-[^'\''\"\s]*)?$' | \ |
There was a problem hiding this comment.
Oh, I get it. Hmm... 1.5.2.1 is a super weird tag name...
Ideally, I'd reject such inputs, but maybe it's fine to accept. I left a suggestion to make the regex simpler but LGTM other than that.
|
Thanks 👍 |
|
🚀 [bumpr] Bumped! New version:v1.3.0 Changes:v1.2.2...v1.3.0 |
Close #29.