Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new version matching syntax support #21

Merged
merged 8 commits into from
Dec 13, 2020
Merged

Adds new version matching syntax support #21

merged 8 commits into from
Dec 13, 2020

Conversation

rickstaa
Copy link
Member

@rickstaa rickstaa commented Dec 12, 2020

This pull request contains the following features:

  • Adds the ability also to match version variables that are enclosed inside of double-quotes.
  • Adds the ability also to match version variables that are enclosed inside single-quotes.
  • Adds the ability also to match version variables that are preceded by multiple spaces.
  • Replaces sed with Perl to make the syntax more clear (no escaping needed).
  • Add the used repo as an output argument such that users can use them in the next jobs.
  • Adds the ability to also automatically updates versions tags that have a - annotation string (like is the case for the reviewdog/nightly branch).

It contains the following bug fixes:

The new regex syntax can be seen in action on this playground. I already created it on my own branch before I saw #19 on the upstream.

In this commit I added support to match the version when it is enclosed
in quotes (Example: REVIEWDOG_VERSION = "v0.1.0"). I also added support
for version tags that contain a - annotation text (example: REVIEWDOG=v0.1.0-nightly20201208+12faa31).
You can check out the regex syntax on https://regex101.com/r/t1JcmL/10.
To see the new regex syntax in action go to
https://regex101.com/r/t1JcmL/13.
This commit updates the create-pull-request action version such that a security vulnerability that is present when using
the `set-env` and `add-path` arguments is fixed. See
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
for more information.
@haya14busa haya14busa merged commit f71e4e4 into reviewdog:master Dec 13, 2020
@haya14busa
Copy link
Member

Thank you for your work, @rickstaa! 👍

@github-actions
Copy link

🚀 [bumpr] Bumped! New version:v1.2.0 Changes:v1.1.0...v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants