Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added a default placeholder color variable for the Input com… #507

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

bolivierjr
Copy link
Contributor

…ponent and added a color parameter to the placeholder mixin.

references issue #503

You are now able to change the placeholder color if needed through a few ways:

  • Change the $input-placeholder-color in _harmonium-component-settings.scss from zip file.
  • Use the harmonium cli to init/build new settings and add $input-placeholder-color to _harmonium-settings.scss (easier way).
  • Use the placeholder mixin, that I added a parameter to, in your apps scss file. Which you're able to change just individual Inputs or all if needed.
    e.g.
<Input className="rev-Input--Foo" placeholder="foo" />`

then in your apps scss file for specific components

.rev-Input--Foo {
    @include placeholder($color-darker-gray);
}

…ponent and added a color parameter to the placeholder mixin.
@bryanjos bryanjos requested a review from CheetoMao March 12, 2020 19:34
@CheetoMao CheetoMao merged commit 8e56a6f into revelrylabs:master Mar 12, 2020
@bolivierjr bolivierjr deleted the 503-feature-placeholder branch March 13, 2020 03:37
@revelry-integrations
Copy link

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants