[672] Add a parameter for including resources when formatting. #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves revelc#672 Signed-off-by: James R. Perkins <[email protected]>
|
As this stands, its a nice improvement. We may want to look at the older way of doing things to avoid collisions in case intent was global override ignoring others but given its flag based its fine. In fact, this is something I see needed on another plugin I work with (htmlcompressor-maven-plugin) for same reasons. Manually trying to capture actual path if were to be done and array based is a guessing game. Anyways, merging this as a good improvement and may toy around a bit afterwards with it when I get some time. |
|
Excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #672
Signed-off-by: James R. Perkins [email protected]