Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolly preload doesn't work with ArchieML integration #81

Closed
VijdanKawoosaTR opened this issue Jun 15, 2023 · 1 comment · Fixed by #88
Closed

Scrolly preload doesn't work with ArchieML integration #81

VijdanKawoosaTR opened this issue Jun 15, 2023 · 1 comment · Fixed by #88

Comments

@VijdanKawoosaTR
Copy link

There's an option for us to set preload count for the srolly element. But when we set that in ArchieML, it is not effective on the project.

For a recent project, @pkd2512 helped me set it manually in the code:

{:else if block.Type === 'ai-scroller'}
{@const newBlock = { ...block, Preload: 0 }}
<Scroller
{...scrollerProps(newBlock, aiCharts, assets || '/')}
embedded="{embedded}"
/>

Is this something we can fix so that it can work directly from ArchieML?

@pkd2512
Copy link
Member

pkd2512 commented Jun 15, 2023

"Preload": "0" doesn't work. "Preload": 0 works
@hobbes7878 Basically the ArchieML parse treats numbers as strings, so it's a problem for all situations when we need int instead of strings.

So, the fix can be in the scrollerProps or our ArchieML parser in general.

@hobbes7878 hobbes7878 linked a pull request Jul 6, 2023 that will close this issue
8 tasks
hobbes7878 added a commit that referenced this issue Jul 6, 2023
…t-work-with-archieml-integration

allow preload in Google block for scroller. closes #81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants