feat: add support for giscus #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #427. |
|
Thanks! Will look into this ASAP! |
|
I'm looking forward to it, please hurry 😋 |
|
waiting for this 😆 |
Merged
reuixiy
reviewed
Jan 20, 2024
There was a problem hiding this comment.
Finally, I’m reviewing this PR now! I’m going to add Giscus support from #397, since this PR contains other changes which makes it harder to merge. I will add @kands-code as one of co-authors at the final merging commit and I’m going to close this PR.
See #397 (review) also.
Thanks for your contribution! Feel free to add another PR for other improvements!
reuixiy
added a commit
to waynerv/hugo-theme-meme
that referenced
this pull request
Jan 20, 2024
reuixiy
added a commit
that referenced
this pull request
Jan 20, 2024
* add giscus support * polish: merge with #428 by hand --------- Co-authored-by: kands-code <[email protected]> Co-authored-by: reuixiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for giscus.