-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper for BossBar packet #990
Conversation
Using adventure's bossbar classes would be a lot nicer to work with |
That's can be difficult as only one action has informations about the full bossbar, else it's only a part of it. Should I add something that is a partial bossbar, return null when not full or do nothing? |
I meant using Bossbar.Color, etc. |
Oh yes, it's good idea. I just made changes about this :) |
could you also parse the flags sent in the packet? |
I'll check. It will require more testing as it's more versions depending |
That's it! :) (Note: please don't forget to squash, it's better) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small issue left, the rest looks good 👍
...ain/java/com/github/retrooper/packetevents/wrapper/play/server/WrapperPlayServerBossBar.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for your PR. |
This PR add a wrapper for
BOSS_BAR
packet.I pre-answer few questions:
Color
enum to prevent switch/case to read color. It also help to other developer to only use right colorsI suggest you to Squash and merge. That's would be perfect.