(WIP) Sponge support #670
Merged
(WIP) Sponge support #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamB440
force-pushed
the
feat/sponge
branch
4 times, most recently
from
322d9bc
to
d3ccefc
Compare
NoJokeFNA
reviewed
Feb 7, 2024
SamB440
force-pushed
the
feat/sponge
branch
3 times, most recently
from
02f90ae
to
e43d1da
Compare
SamB440
force-pushed
the
feat/sponge
branch
2 times, most recently
from
c0ce8a0
to
b508456
Compare
SamB440
force-pushed
the
feat/sponge
branch
2 times, most recently
from
d37d660
to
5b45251
Compare
|
Update for those unaware: viaversion support doesn't seem to be possible because on Sponge they replace the vanilla handler, instead of adding their own. |
SamB440
force-pushed
the
feat/sponge
branch
2 times, most recently
from
c0694e2
to
09ea2a2
Compare
SamB440
force-pushed
the
feat/sponge
branch
2 times, most recently
from
09345e9
to
ee3f984
Compare
SamB440
force-pushed
the
feat/sponge
branch
4 times, most recently
from
a0fa9f7
to
d1f7075
Compare
SamB440
force-pushed
the
feat/sponge
branch
2 times, most recently
from
46acabd
to
aaf5959
Compare
SamB440
force-pushed
the
feat/sponge
branch
6 times, most recently
from
6483acd
to
b560d70
Compare
SamB440
force-pushed
the
feat/sponge
branch
3 times, most recently
from
4b1e3e3
to
e7225e4
Compare
|
I think I might migrate the current injection stuff to be mixin-based like fabric |
They have fixed this recently. |
|
You can mark this as a PR. |
SamB440
force-pushed
the
feat/sponge
branch
2 times, most recently
from
f0981e6
to
76e99bf
Compare
SamB440
force-pushed
the
feat/sponge
branch
from
3ad2e76
to
2e8088a
Compare
|
Is this fully functional? |
|
Yes |
SamB440
force-pushed
the
feat/sponge
branch
from
2e8088a
to
24ffd9e
Compare
|
Thank you a lot for porting PacketEvents to Sponge! |
|
Next update, it should be listed as supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Sponge support. A lot is copied from the Spigot module as they are fundamentally similar and via runs on Sponge too.
The only conversion util I made is itemstack conversion. Most things can be done via Sponge API or VanillaGradle anyway.
Also fixed use of deprecatedjava.sourceCompatibilityandjava.targetCompatibility(need to confirm it compiles to 8 bytecode again).