Specialization: avoid temporary lists/tuples and avoid entry in the type history when a no-op #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also avoid some allocations when an operand of `++` empty.
|
Previously proposed as scala#7863 but the patch is still bigger/uglier than I'd like, so un-proposed for now. |
diesalbla
reviewed
May 28, 2019
| @@ -72,8 +74,47 @@ abstract class SpecializeTypes extends InfoTransform with TypingTransformers { | |||
| override def changesBaseClasses = true | |||
| override def keepsTypeParams = true | |||
|
|
|||
| type TypeEnv = immutable.Map[Symbol, Type] | |||
| def emptyEnv: TypeEnv = Map[Symbol, Type]() | |||
| final case class TypeEnvWrapper(value: immutable.Map[Symbol, Type]) { | |||
There was a problem hiding this comment.
Why is TypeEnvWrapper a case class, instead of a class that extends from AnyVal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.