Omnibus of -Yprofile-trace, -Ymacro-classpath, Global.close(), -Youtline, build pipelining and pickle caching #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suitable for viewing directly in chrome://tracing, or post processing with https://github.com/retronym/chrome-trace-to-flamegraph Co-Authored-By: Mike Skells <[email protected]>
For better cacheability (cherry picked from commit 24124d5)
(cherry picked from commit 5175550)
An extension point analagous to `findMacroClassLoader` (cherry picked from commit 01a9dbd)
This lets customized Global's deliver this file, and offloads the scanning logic. (cherry picked from commit bec5899)
(cherry picked from commit 837f924)
Close Global-scoped JARs and ClassLoaders. Entries of FileBasedCache that have a lifetime that exceeds any single Global instance are reference counted. When the count hits zero, it is closed if no references appear after a delay. (cherry picked from commit deb10d4)
…asspath' into topic/pipeline-trace-macro-omnibus
…to topic/pipeline-trace-macro-omnibus
(cherry picked from commit a5869ce)
viktorklang
reviewed
Oct 31, 2018
Co-Authored-By: retronym <[email protected]>
Since the changes to make the compiler output deterministic, default getter symbols must be entered eagerly before the trees are created. This happens in `enterDefDef`, but that method is bypassed when entering the synthetic symbol for an implicit class factory method. This commit enters the default getter symbols in this case, as well, avoiding a later crash.
retronym
force-pushed
the
topic/pipeline-trace-macro-omnibus
branch
from
242b0ff to
81e3918
Compare
- Don't print `-Xprint-args ...` itself
- Render a programattically added single output directory as -d.
Zinc sets the output directory in this way.
```
scala> import scala.tools.nsc._; val g = new Global(new Settings); g.settings.outputDirs.setSingleOutput("/tmp"); g.settings.printArgs.value = "-"; val run = new g.Run(); run.compileSources(g.newSourceFile("") :: Nil)
-d
/tmp
<console>
import scala.tools.nsc._
```
retronym
force-pushed
the
topic/pipeline-trace-macro-omnibus
branch
from
81e3918 to
5779bbd
Compare
Also test that the Java parser doesn't force entry of new symbols when it parses modifiers that it translates into symbol annotations. Regressed in scala#7356
Omnibus tweaks
- Fix pickle hand off for modules without a companion class
- Block javac compilation on current module's scala compilation
(same as CompileOrder.Mixed in SBT)
retronym
force-pushed
the
topic/pipeline-trace-macro-omnibus
branch
from
46bbcf7 to
b3a9abe
Compare
This reverts commit b3a9abe.
They can either be a stripped .class file or directly contain the Scala pickle. Rework PipelineMain to use this. Remove the more general extension points in ClassPathPlugin Call global.close() from PipelineMain
retronym
force-pushed
the
topic/pipeline-trace-macro-omnibus
branch
from
973c625 to
d9a4252
Compare
retronym
force-pushed
the
topic/pipeline-trace-macro-omnibus
branch
from
d9a4252 to
b74afb4
Compare
and show all times in "done" log messages
retronym
force-pushed
the
topic/pipeline-trace-macro-omnibus
branch
from
c391769 to
e4bf7e8
Compare
|
All merged to 2.12.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.