internal: fix linter issues

retroenv · Mar 12, 2024 · 99bfbd2 · 99bfbd2
1 parent d277fda
commit 99bfbd2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/internal/code.go b/internal/code.go
@@ -71,9 +71,9 @@ func (dis *Disasm) handleJumpIntoInstruction(address uint16) {
 
 	offsetInfo := dis.mapper.offsetInfo(address)
 	if offsetInfo.Code == "" { // disambiguous instruction
-		offsetInfo.Comment = fmt.Sprintf("branch into instruction detected: %s", offsetInfo.Comment)
+		offsetInfo.Comment = "branch into instruction detected: " + offsetInfo.Comment
 	} else {
-		offsetInfo.Comment = fmt.Sprintf("branch into instruction detected: %s", offsetInfo.Code)
+		offsetInfo.Comment = "branch into instruction detected: " + offsetInfo.Code
 		offsetInfo.Code = ""
 	}
 
@@ -97,9 +97,9 @@ func (dis *Disasm) handleDisambiguousInstructions(address uint16, offsetInfo *of
 	}
 
 	if offsetInfo.Code == "" { // in case of branch into unofficial nop instruction detected
-		offsetInfo.Comment = fmt.Sprintf("disambiguous instruction: %s", offsetInfo.Comment)
+		offsetInfo.Comment = "disambiguous instruction: " + offsetInfo.Comment
 	} else {
-		offsetInfo.Comment = fmt.Sprintf("disambiguous instruction: %s", offsetInfo.Code)
+		offsetInfo.Comment = "disambiguous instruction: " + offsetInfo.Code
 	}
 
 	offsetInfo.Code = ""

diff --git a/internal/disasm.go b/internal/disasm.go
@@ -358,7 +358,7 @@ func getProgramOffset(address uint16, offsetInfo offset, options *options.Disass
 		}
 
 		if offsetInfo.IsType(program.FunctionReference) {
-			programOffset.Code = fmt.Sprintf(".word %s", offsetInfo.branchingTo)
+			programOffset.Code = ".word " + offsetInfo.branchingTo
 		}
 
 		if err := setComment(address, &programOffset, options); err != nil {

diff --git a/internal/disasm_test.go b/internal/disasm_test.go
@@ -37,7 +37,7 @@ func TestDisasmZeroDataReference(t *testing.T) {
         .byte $00                        ; $8020
 `
 
-	setup := func(options *options.Disassembler, cart *cartridge.Cartridge) {
+	setup := func(_ *options.Disassembler, cart *cartridge.Cartridge) {
 		cart.PRG[0x0010] = 0x12
 		cart.PRG[0x0015] = 0x34
 	}
@@ -282,7 +282,7 @@ func TestDisasmDifferentCodeBaseAddress(t *testing.T) {
         rti                            ; $C006  40
 `
 
-	setup := func(options *options.Disassembler, cart *cartridge.Cartridge) {
+	setup := func(_ *options.Disassembler, cart *cartridge.Cartridge) {
 		cart.PRG = make([]byte, 0x4000)
 		cart.PRG[0x3FFD] = 0xC0 // reset handler that forces base address to $C000
 	}
@@ -298,7 +298,7 @@ func TestDisasmIndirectJmp(t *testing.T) {
         jmp ($20CE)                    ; $8000  6C CE 20
 `
 
-	setup := func(options *options.Disassembler, cart *cartridge.Cartridge) {}
+	setup := func(_ *options.Disassembler, _ *cartridge.Cartridge) {}
 
 	runDisasm(t, setup, input, expected)
 }